Issue 12408007: Disable analyzer-test checking for string.+.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12408007: Disable analyzer-test checking for string.+. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable analyzer-test checking for string.+. It doesn't recognize that String has an operator+. Committed: https://code.google.com/p/dart/source/detail?r=19801

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

TBR I didn't find a way to make the test work, so I disabled it.

7 years, 9 months ago (2013-03-11 16:05:12 UTC) #1

Lasse Reichstein Nielsen

Committed patchset #1 manually as r19801 (presubmit successful).

7 years, 9 months ago (2013-03-11 16:05:55 UTC) #2

floitsch

7 years, 9 months ago (2013-03-11 16:16:08 UTC) #3

Message was sent while issue was closed.

LGTM. (usually we open an issue number and use that for the renaming:
issue377test ...)
But I think it's easy enough for Konstantin and we won't forget.

Expand Messages | Collapse Messages