Issue 12408004: Fix checked mode error on socket IOSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12408004: Fix checked mode error on socket IOSink (Closed)

Created:
7 years, 9 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix checked mode error on socket IOSink The set encoding method on a Sockets IOSink implementation failed in checked mode. Added a test calling all IOSink methods on a socket. BUG=https://code.google.com/p/dart/issues/detail?id=9020 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=19803

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -1 line)			Patch
M	runtime/bin/socket_patch.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/io/io_sink.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/standalone/io/stdout_stderr_test.dart	View	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 9 months ago (2013-03-11 16:16:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19803 (presubmit successful).

Expand Messages | Collapse Messages