Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 12407005: Adding tests for Element & Node lists insert method. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
Emily Fortuna, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding tests for Element & Node lists insert method. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 9 months ago (2013-03-14 22:48:32 UTC) #1
blois
7 years, 9 months ago (2013-03-15 23:39:43 UTC) #2
Emily Fortuna
lgtm
7 years, 9 months ago (2013-03-15 23:48:53 UTC) #3
blois
7 years, 9 months ago (2013-03-15 23:58:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698