Adding Angular and dependent packages for testing

Adding Angular and dependent packages for testing

This adds Angular tests to run in Dart's test suite.

Notes-
 - All files under pkg/third_party/angular_test are auto-generated by update_angular.sh
 - All files under third_party/pkg/angular are from Angular sources (with the exception of REVISION)

Modifed / Created files:
 - third_party/pkg/update_perf.sh
 - third_party/pkg/update_route_hierarchical.sh
 - third_party/pkg/update_perf.sh
 - third_party/pkg/update_all.sh
 - third_party/pkg/update_di.sh
 - third_party/pkg/update_js.sh
 - third_party/pkg/update_angular.sh
 - pkg/pkg.status

BUG=
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31518

[Siggi Cherem (dart-lang), 2014-01-03 22:21:10]

very cool :), lgtm - just minor suggestions below

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
File third_party/pkg/update_all.sh (right):

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_all.sh:13: ./update_route_hierarchical.sh
if we had the function, then here it could be done dynamically

. update.sh # defines update_package

for dir in *; do
  if [[ -d $dir ]]; then
    update_package $dir
  fi
done

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
File third_party/pkg/update_angular.sh (right):

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:23: pushd test  > /dev/null
nit: remove 1 space (test__>)

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:33: mkdir -p "${OUT_DIR}/${test_dir:2}"
let's add a comment of why :2 (removing the ./ from find, I assume?)

Maybe we can do the :2 only once (e.g. src_file=${src_file:2} upfront).
Alternatively, if you call 'find *' instead of 'find .', the output might be
closer to what you want.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:36: dots=$(echo "$(dirname "${src_file}")/"  |
sed -e "s/[^\/]\+/../g")
since you already have $test_dir, use that instead?

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:40: configuration=""
vm_config.dart / useVMConfiguration?
or even
compact_vm_config.dart / useCompactVMConfiguration?

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:45: /// auto-generated by
generate_angular_tests.sh
'generate_angular_tests.sh' => 'third_party/pkg/update_angular.sh'

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:47: // Copyright (c) 2014, the Dart project
authors.  Please see the AUTHORS file
2014! nice :)

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:69: done
consider adding indentation here to match the indent at `cat`?

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
File third_party/pkg/update_route_hierarchical.sh (right):

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_route_hierarchical.sh:24: echo "*** Updated to revision
$REVISION"
I'm ok either way, but since this code is so similar among all scripts, another
option is to put the code in a function make it a shared library.

[blois, 2014-01-04 01:13:59]

Broke out the other packages, but it didn't help much. A decent refactoring of
update_angular.sh though.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
File third_party/pkg/update_angular.sh (right):

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:23: pushd test  > /dev/null
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> nit: remove 1 space (test__>)

Done.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:33: mkdir -p "${OUT_DIR}/${test_dir:2}"
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> let's add a comment of why :2 (removing the ./ from find, I assume?)
> 
> Maybe we can do the :2 only once (e.g. src_file=${src_file:2} upfront).
> Alternatively, if you call 'find *' instead of 'find .', the output might be
> closer to what you want.

Done.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:40: configuration=""
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> vm_config.dart / useVMConfiguration?
> or even
> compact_vm_config.dart / useCompactVMConfiguration?

Done.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:45: /// auto-generated by
generate_angular_tests.sh
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> 'generate_angular_tests.sh' => 'third_party/pkg/update_angular.sh'

Done.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:47: // Copyright (c) 2014, the Dart project
authors.  Please see the AUTHORS file
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> 2014! nice :)

Done.

https://codereview.chromium.org/124053002/diff/350052/third_party/pkg/update_...
third_party/pkg/update_angular.sh:69: done
On 2014/01/03 22:21:13, Siggi Cherem (dart-lang) wrote:
> consider adding indentation here to match the indent at `cat`?

Done.

[Siggi Cherem (dart-lang), 2014-01-04 01:16:36]

lgtm

https://codereview.chromium.org/124053002/diff/1240016/third_party/pkg/update...
File third_party/pkg/update_angular.sh (right):

https://codereview.chromium.org/124053002/diff/1240016/third_party/pkg/update...
third_party/pkg/update_angular.sh:26: local import_file="$(echo "$(dirname
"./${src_file}")/" \
would it work here to just use echo $test_dir ?

[blois, 2014-01-06 23:11:09]

Committed patchset #2 manually as r31518 (presubmit successful).