Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1240433008: Renames to move closer to the new API (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M pkg/analysis_server/lib/completion/completion_core.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/completion/completion_dart.dart View 4 chunks +29 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 4 chunks +11 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 5 months ago (2015-07-17 13:16:38 UTC) #2
danrubel
LGTM. Thanks for pushing this forward.
5 years, 5 months ago (2015-07-17 17:28:38 UTC) #3
Brian Wilkerson
5 years, 5 months ago (2015-07-17 19:20:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23f96f191677f0e6a05ff7023070fc0a665ed797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698