Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1240363003: Update status for Chrome 44 on dart2js tests. (Closed)

Created:
5 years, 5 months ago by Bill Hesse
Modified:
5 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -54 lines) Patch
M tests/co19/co19-dart2js.status View 20 chunks +34 lines, -53 lines 2 comments Download
M tests/html/html.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
Also removed some duplicate consecutive lines in co19-dart2js status.
5 years, 5 months ago (2015-07-22 15:30:24 UTC) #2
kustermann
lgtm https://codereview.chromium.org/1240363003/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/1240363003/diff/1/tests/co19/co19-dart2js.status#newcode559 tests/co19/co19-dart2js.status:559: +[ $compiler == dart2js && $runtime == chrome ...
5 years, 5 months ago (2015-07-22 15:35:17 UTC) #3
Bill Hesse
Fixed the syntax error. https://codereview.chromium.org/1240363003/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/1240363003/diff/1/tests/co19/co19-dart2js.status#newcode559 tests/co19/co19-dart2js.status:559: +[ $compiler == dart2js && ...
5 years, 5 months ago (2015-07-22 16:00:56 UTC) #4
Bill Hesse
5 years, 5 months ago (2015-07-22 16:02:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0bb497875a52f280112ef3187c0a2165af22bd8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698