Issue 1240283004: few small analyzer AST visitor fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1240283004: few small analyzer AST visitor fixes (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly

Modified:
5 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

few small analyzer fixes ResolutionCopier.visitLibraryDirective now copies its element AstCloner.visitVariableDeclarationList now copies the comment. (otherwise ResolutionCopier thinks the tree structure doesn't match) R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/646c84762d14e2bb137f9adcc6eb0d3f03662f69

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

Just a few things I came across while looking at https://github.com/dart-lang/dev_compiler/issues/259. I bumped the pubspec, ...

5 years, 5 months ago (2015-07-21 00:04:04 UTC) #2

Brian Wilkerson

LGTM. I don't know of any reason not to publish this version.

5 years, 5 months ago (2015-07-21 14:00:02 UTC) #3

Jennifer Messerly

5 years, 5 months ago (2015-07-21 19:42:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
646c84762d14e2bb137f9adcc6eb0d3f03662f69 (presubmit successful).