Issue 12400002: Add individual HTTP request to web socket upgrade support

Issue 12400002: Add individual HTTP request to web socket upgrade support (Closed)

Created:
7 years, 9 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add individual HTTP request to web socket upgrade support Added the static method "upgrade" on the WebSocketTransformer class to allow upgrading individual HTTPRequest objects to web scoket connections. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19395

Patch Set 1 #

Total comments: 4

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -38 lines)			Patch
M	sdk/lib/io/websocket.dart	View	1 chunk	+38 lines, -9 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1 chunk	+31 lines, -29 lines	0 comments	Download
M	tests/standalone/io/web_socket_test.dart	View	2 chunks	+52 lines, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socket_test.dart File tests/standalone/io/web_socket_test.dart (right): https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socket_test.dart#newcode293 tests/standalone/io/web_socket_test.dart:293: int closeCount = 0; Unused? https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socket_test.dart#newcode326 tests/standalone/io/web_socket_test.dart:326: client.openUrl("GET", ...

7 years, 9 months ago (2013-03-04 14:41:57 UTC) #2

Søren Gjesse

Committed patchset #1 manually as r19395 (presubmit successful).

7 years, 9 months ago (2013-03-04 15:50:09 UTC) #3

Søren Gjesse

7 years, 9 months ago (2013-03-04 15:50:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socke...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socke...
tests/standalone/io/web_socket_test.dart:293: int closeCount = 0;
On 2013/03/04 14:41:57, Anders Johnsen wrote:
> Unused?

Removed.

https://codereview.chromium.org/12400002/diff/1/tests/standalone/io/web_socke...
tests/standalone/io/web_socket_test.dart:326: client.openUrl("GET", new
Uri.fromString('${baseHttpUrl}'))
On 2013/03/04 14:41:57, Anders Johnsen wrote:
> Add the result of client.openUrl directl to futures instead of using a
> completer.

Done.

Expand Messages | Collapse Messages