Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12398029: Remove the barely used macro assemblers after merging their contents to the base (Closed)

Created:
7 years, 9 months ago by regis
Modified:
7 years, 9 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the barely used macro assemblers after merging their contents to the base assemblers. Committed: https://code.google.com/p/dart/source/detail?r=19434

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -697 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 2 chunks +53 lines, -0 lines 0 comments Download
D runtime/vm/assembler_macros.h View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/vm/assembler_macros_arm.h View 1 chunk +0 lines, -56 lines 0 comments Download
D runtime/vm/assembler_macros_arm.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D runtime/vm/assembler_macros_ia32.h View 1 chunk +0 lines, -82 lines 0 comments Download
D runtime/vm/assembler_macros_ia32.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D runtime/vm/assembler_macros_mips.h View 1 chunk +0 lines, -54 lines 0 comments Download
D runtime/vm/assembler_macros_mips.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D runtime/vm/assembler_macros_x64.h View 1 chunk +0 lines, -82 lines 0 comments Download
D runtime/vm/assembler_macros_x64.cc View 1 chunk +0 lines, -79 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 7 chunks +24 lines, -31 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 6 chunks +20 lines, -26 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 20 chunks +19 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 20 chunks +19 lines, -20 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
Just a mechanical change.
7 years, 9 months ago (2013-03-04 22:53:47 UTC) #1
zra
lgtm
7 years, 9 months ago (2013-03-04 23:44:07 UTC) #2
srdjan
LGTM (comments optional, since existing code) https://codereview.chromium.org/12398029/diff/1/runtime/vm/assembler_arm.h File runtime/vm/assembler_arm.h (right): https://codereview.chromium.org/12398029/diff/1/runtime/vm/assembler_arm.h#newcode596 runtime/vm/assembler_arm.h:596: // Set up ...
7 years, 9 months ago (2013-03-04 23:46:43 UTC) #3
regis
Thanks https://codereview.chromium.org/12398029/diff/1/runtime/vm/assembler_arm.h File runtime/vm/assembler_arm.h (right): https://codereview.chromium.org/12398029/diff/1/runtime/vm/assembler_arm.h#newcode596 runtime/vm/assembler_arm.h:596: // Set up a dart frame on entry ...
7 years, 9 months ago (2013-03-04 23:51:24 UTC) #4
regis
7 years, 9 months ago (2013-03-05 00:04:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r19434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698