Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1239653003: Fixed a few more things to make Dartium build w/o --gen-interop (Closed)

Created:
5 years, 5 months ago by terry
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed a few more things to make Dartium build w/o --gen-interop TBR=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/1fa61ee114dd76eebd05b7feab21b7007333a07f

Patch Set 1 #

Patch Set 2 : Re-enable analyzer tests - now pass. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -41 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +19 lines, -17 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 1 chunk +1 line, -9 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +14 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
terry
5 years, 5 months ago (2015-07-14 14:18:12 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1fa61ee114dd76eebd05b7feab21b7007333a07f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698