Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1239623005: "pub cache repair" prints a more detailed summary. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

"pub cache repair" prints a more detailed summary. Now instead of just saying how many packages failed to be reinstalled/reactivated, "pub cache repair" will print a list of those packages. This also fixes an issue where "pub cache repair" would incorrectly return a 0 exit code when packages failed to reactivate. Closes #1301 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/bbe564d5b849b96cf5f86ba39cdea6c46ad62a69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -43 lines) Patch
M lib/src/command/cache_repair.dart View 1 chunk +33 lines, -18 lines 0 comments Download
M lib/src/global_packages.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M lib/src/source/cached.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/src/source/git.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M lib/src/source/hosted.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cache/repair/handles_corrupted_global_lockfile_test.dart View 2 chunks +4 lines, -1 line 0 comments Download
M test/cache/repair/handles_failure_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/version_solver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-15 20:11:06 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-07-15 20:22:42 UTC) #2
nweiz
5 years, 5 months ago (2015-07-15 20:38:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbe564d5b849b96cf5f86ba39cdea6c46ad62a69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698