Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1239613002: Factor out a Runner class from executable.dart. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Factor out a Runner class from executable.dart. This is useful as an object because it provides all the private methods with full access to the configuration, the engine, and the loader without having to pass them around or create top-level variables. It also creates a cleaner distinction between receiving a signal and closing various components. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/218f9925609a8835caf66cbe42bc5f7bb005e94a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -132 lines) Patch
M lib/src/executable.dart View 1 5 chunks +18 lines, -132 lines 0 comments Download
A lib/src/runner.dart View 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 5 months ago (2015-07-14 01:34:36 UTC) #1
kevmoo
LGTM w/ one nit https://codereview.chromium.org/1239613002/diff/1/lib/src/executable.dart File lib/src/executable.dart (right): https://codereview.chromium.org/1239613002/diff/1/lib/src/executable.dart#newcode19 lib/src/executable.dart:19: import 'util/io.dart'; unused import
5 years, 5 months ago (2015-07-14 01:44:16 UTC) #2
nweiz
Code review changes
5 years, 5 months ago (2015-07-14 19:42:31 UTC) #3
nweiz
https://codereview.chromium.org/1239613002/diff/1/lib/src/executable.dart File lib/src/executable.dart (right): https://codereview.chromium.org/1239613002/diff/1/lib/src/executable.dart#newcode19 lib/src/executable.dart:19: import 'util/io.dart'; On 2015/07/14 01:44:16, kevmoo wrote: > unused ...
5 years, 5 months ago (2015-07-14 19:42:51 UTC) #4
nweiz
5 years, 5 months ago (2015-07-14 19:42:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
218f9925609a8835caf66cbe42bc5f7bb005e94a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698