Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1239543002: add footer for dartdocs generated for the sdk for analytics and survey (Closed)

Created:
5 years, 5 months ago by keertip
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse, sethladd
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add footer for dartdocs generated for the sdk for analytics and survey BUG= R=sethladd@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/d2a067e22b5458f39eb9df58a8cfcf3adf21f7c5

Patch Set 1 #

Patch Set 2 : fix footer #

Patch Set 3 : fix footer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M tools/bots/dart_sdk.py View 1 chunk +4 lines, -2 lines 0 comments Download
A tools/bots/dartdoc_footer.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
keertip
5 years, 5 months ago (2015-07-13 17:12:46 UTC) #2
Bill Hesse
The code LGTM, but do we have approval that putting this in is right, and ...
5 years, 5 months ago (2015-07-13 17:38:33 UTC) #3
sethladd
HTML is lgtm This is just for api.dartlang.org. We aren't shipping these codes in the ...
5 years, 5 months ago (2015-07-13 17:40:28 UTC) #4
keertip
On 2015/07/13 17:38:33, Bill Hesse wrote: > The code LGTM, but do we have approval ...
5 years, 5 months ago (2015-07-13 20:07:09 UTC) #5
keertip
5 years, 5 months ago (2015-07-13 20:15:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d2a067e22b5458f39eb9df58a8cfcf3adf21f7c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698