Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1239513005: Switch on null-aware operators by default in analyzer. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch on null-aware operators by default in analyzer. Patches to update analyzer_cli and analysis_server will follow once a new version of analyzer has been published. BUG=dartbug.com/23793 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4b832198478bcc1e11e964aa2718fb2324dfac17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -139 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 8 chunks +10 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_scanner.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 7 chunks +0 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 4 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 11 chunks +0 lines, -23 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 3 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 4 chunks +0 lines, -12 lines 0 comments Download
M tests/language/conditional_method_invocation_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/conditional_property_access_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/conditional_property_assignment_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/conditional_property_increment_decrement_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/if_null_assignment_behavior_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/if_null_assignment_static_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/if_null_behavior_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/if_null_evaluation_order_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/if_null_precedence_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/nullaware_opt_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/super_conditional_operator_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/this_conditional_operator_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-07-13 21:24:19 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-13 21:38:46 UTC) #3
Paul Berry
5 years, 5 months ago (2015-07-13 22:56:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4b832198478bcc1e11e964aa2718fb2324dfac17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698