Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 12395024: Don't throw if a non-string is passed to RegExpMatcher. (Closed)

Created:
7 years, 9 months ago by gram
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't throw if a non-string is passed to RegExpMatcher. See https://code.google.com/p/dart/issues/detail?id=8881 Committed: https://code.google.com/p/dart/source/detail?r=19426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/unittest/lib/src/string_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 9 months ago (2013-03-04 21:48:36 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 9 months ago (2013-03-04 21:49:43 UTC) #2
gram
7 years, 9 months ago (2013-03-04 22:10:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698