Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12395017: dart:io | Fix a crash when read was called on a closed socket on Windows. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Fix a crash when read was called on a closed socket on Windows. BUG=dartbug.com/8798 Committed: https://code.google.com/p/dart/source/detail?r=19396

Patch Set 1 #

Patch Set 2 : Remove intense test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -58 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
D tests/standalone/io/raw_secure_server_socket_intense_test.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
7 years, 9 months ago (2013-03-04 16:06:49 UTC) #1
Søren Gjesse
LGTM How about deleting the intense test as well.
7 years, 9 months ago (2013-03-04 16:12:37 UTC) #2
Bill Hesse
On 2013/03/04 16:12:37, Søren Gjesse wrote: > LGTM > > How about deleting the intense ...
7 years, 9 months ago (2013-03-04 16:13:05 UTC) #3
Bill Hesse
On 2013/03/04 16:13:05, Bill Hesse wrote: > On 2013/03/04 16:12:37, Søren Gjesse wrote: > > ...
7 years, 9 months ago (2013-03-04 16:13:46 UTC) #4
Bill Hesse
7 years, 9 months ago (2013-03-04 16:16:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698