Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 12395011: Fix type annotation on [JSArray.addAll] and add a test. (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type annotation on [JSArray.addAll] and add a test. Committed: https://code.google.com/p/dart/source/detail?r=19389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/corelib/iterable_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 9 months ago (2013-03-04 14:35:31 UTC) #1
floitsch
LGTM!
7 years, 9 months ago (2013-03-04 14:49:55 UTC) #2
ngeoffray
7 years, 9 months ago (2013-03-04 14:50:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698