Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1239493002: error can shift more than 32 bits. (Closed)

Created:
5 years, 5 months ago by koda
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/third_party/double-conversion/src/strtod.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
We should do a full pull of this dependency at some point in the future, ...
5 years, 5 months ago (2015-07-13 14:14:46 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-13 14:59:14 UTC) #3
koda
5 years, 5 months ago (2015-07-13 15:50:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3a9aa21d6da0cb8be2441e5241c1d5b096284c0.

Powered by Google App Engine
This is Rietveld 408576698