Issue 12393020: Fix build break with dart2js not liking conditional expressions in initializers of const classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12393020: Fix build break with dart2js not liking conditional expressions in initializers of const classes. (Closed)

Created:
7 years, 9 months ago by gram

Modified:
7 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix build break with dart2js not liking conditional expressions in initializers of const classes. Committed: https://code.google.com/p/dart/source/detail?r=19341

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/unittest/lib/src/future_matchers.dart	View		2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/12393020/diff/1/pkg/unittest/lib/src/future_matchers.dart File pkg/unittest/lib/src/future_matchers.dart (right): https://codereview.chromium.org/12393020/diff/1/pkg/unittest/lib/src/future_matchers.dart#newcode46 pkg/unittest/lib/src/future_matchers.dart:46: var id = _id == '' ? '' ...

7 years, 9 months ago (2013-03-01 22:17:15 UTC) #2

gram

7 years, 9 months ago (2013-03-01 22:20:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19341 (presubmit successful).

Expand Messages | Collapse Messages