Fix issue with async callbacks that get called synchronously while running test case function causi…

Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.

Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Committed: https://code.google.com/p/dart/source/detail?r=19339

[Siggi Cherem (dart-lang), 2013-03-01 21:11:19]

lgtm

https://codereview.chromium.org/12393017/diff/1/pkg/unittest/lib/src/future_m...
File pkg/unittest/lib/src/future_matchers.dart (right):

https://codereview.chromium.org/12393017/diff/1/pkg/unittest/lib/src/future_m...
pkg/unittest/lib/src/future_matchers.dart:37: const _Completes(this._matcher,
String id) :
style nit: move the ':' to the next line:


  const _Completes(this._matcher, String id)
      : this._id = ...;

[gram, 2013-03-01 21:49:22]

Committed patchset #2 manually as r19339 (presubmit successful).

[gram, 2013-03-04 19:53:40]

https://codereview.chromium.org/12393017/diff/1/pkg/unittest/lib/src/future_m...
File pkg/unittest/lib/src/future_matchers.dart (right):

https://codereview.chromium.org/12393017/diff/1/pkg/unittest/lib/src/future_m...
pkg/unittest/lib/src/future_matchers.dart:37: const _Completes(this._matcher,
String id) :
On 2013/03/01 21:11:20, Siggi Cherem (dart-lang) wrote:
> style nit: move the ':' to the next line:
> 
> 
>   const _Completes(this._matcher, String id)
>       : this._id = ...;

Done.