Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 12393005: When the socket is closed, we can end up trying to send a close packet, before we get the async 'so… (Closed)

Created:
7 years, 9 months ago by Anders Johnsen
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

When the socket is closed, we can end up trying to send a close packet, before we get the async 'socket closed' event. BUG=https://code.google.com/p/dart/issues/detail?id=8824 Committed: https://code.google.com/p/dart/source/detail?r=19301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M sdk/lib/io/websocket_impl.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 9 months ago (2013-03-01 10:08:02 UTC) #1
Søren Gjesse
lgtm
7 years, 9 months ago (2013-03-01 11:55:11 UTC) #2
Anders Johnsen
7 years, 9 months ago (2013-03-01 12:31:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698