Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 12391076: Tweak mismatch description message to check for Iterable, not Collection. (Closed)

Created:
7 years, 9 months ago by gram
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweak mismatch description message to check for Iterable, not Collection. See https://code.google.com/p/dart/issues/detail?id=8880 Committed: https://code.google.com/p/dart/source/detail?r=19428

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/unittest/lib/src/collection_matchers.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gram
7 years, 9 months ago (2013-03-04 21:58:10 UTC) #1
gram
7 years, 9 months ago (2013-03-04 21:58:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/12391076/diff/1/pkg/unittest/lib/src/collection_matchers.dart File pkg/unittest/lib/src/collection_matchers.dart (right): https://codereview.chromium.org/12391076/diff/1/pkg/unittest/lib/src/collection_matchers.dart#newcode192 pkg/unittest/lib/src/collection_matchers.dart:192: if (item is !Iterable) { nit: this should ...
7 years, 9 months ago (2013-03-04 22:13:55 UTC) #3
gram
https://codereview.chromium.org/12391076/diff/1/pkg/unittest/lib/src/collection_matchers.dart File pkg/unittest/lib/src/collection_matchers.dart (right): https://codereview.chromium.org/12391076/diff/1/pkg/unittest/lib/src/collection_matchers.dart#newcode192 pkg/unittest/lib/src/collection_matchers.dart:192: if (item is !Iterable) { On 2013/03/04 22:13:55, Siggi ...
7 years, 9 months ago (2013-03-04 22:23:25 UTC) #4
gram
7 years, 9 months ago (2013-03-04 22:23:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698