Issue 12391060: In LoadOptimizer::EmitPhis check for environment uses of phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12391060: In LoadOptimizer::EmitPhis check for environment uses of phis. (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

In LoadOptimizer::EmitPhis check for environment uses of phis. Previously we checked for input uses only. This caused some phis to be not emitted if they had only environment uses. The bug was masked by an elimination pass done before the register allocation. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=19390

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/language/store_to_load_forwarding_phis_vm_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

7 years, 9 months ago (2013-03-04 14:55:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19390 (presubmit successful).

Expand Messages | Collapse Messages