Add List.asMap().

Add List.asMap().

Committed: https://code.google.com/p/dart/source/detail?r=19399

[Lasse Reichstein Nielsen, 2013-03-04 08:28:37]

lgtm

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
File sdk/lib/_collection_dev/list.dart (right):

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
sdk/lib/_collection_dev/list.dart:273: Iterable<int> get keys => new
_ListIndexIterable(_values);
_ListIndicesIterable?

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
sdk/lib/_collection_dev/list.dart:277: bool containsKey(int key) => key is int
&& key >= 0 && key < length;
Drop the "key is int".

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart#newcod...
sdk/lib/core/list.dart:259: * Returns a [Map] view of `this`.
Unmodifiable?

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart#newcod...
sdk/lib/core/list.dart:262: * list as values.
It has the indices of this list as keys, and the corresponding elements as
values.

https://codereview.chromium.org/12391046/diff/1/tests/corelib/list_as_map_tes...
File tests/corelib/list_as_map_test.dart (right):

https://codereview.chromium.org/12391046/diff/1/tests/corelib/list_as_map_tes...
tests/corelib/list_as_map_test.dart:55: if (!canBeModified) return;
Instead of passing anonymous booleans, you can have three functions:
testConstAsMap, testFixedAsMap, testAsMap, with that last two  calling the prior
one as well as adding its own tests.

[floitsch, 2013-03-04 16:50:20]

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
File sdk/lib/_collection_dev/list.dart (right):

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
sdk/lib/_collection_dev/list.dart:273: Iterable<int> get keys => new
_ListIndexIterable(_values);
On 2013/03/04 08:28:37, Lasse Reichstein Nielsen wrote:
> _ListIndicesIterable?

Done.

https://codereview.chromium.org/12391046/diff/1/sdk/lib/_collection_dev/list....
sdk/lib/_collection_dev/list.dart:277: bool containsKey(int key) => key is int
&& key >= 0 && key < length;
On 2013/03/04 08:28:37, Lasse Reichstein Nielsen wrote:
> Drop the "key is int".

The key is int is crucial. Otherwise it will return true for things that aren't
in it.
Since we decide to move towards accepting any Object (removing the type in the
signature) I will keep it.

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart#newcod...
sdk/lib/core/list.dart:259: * Returns a [Map] view of `this`.
On 2013/03/04 08:28:37, Lasse Reichstein Nielsen wrote:
> Unmodifiable?

Done.

https://codereview.chromium.org/12391046/diff/1/sdk/lib/core/list.dart#newcod...
sdk/lib/core/list.dart:262: * list as values.
On 2013/03/04 08:28:37, Lasse Reichstein Nielsen wrote:
> It has the indices of this list as keys, and the corresponding elements as
> values.

Done.

https://codereview.chromium.org/12391046/diff/1/tests/corelib/list_as_map_tes...
File tests/corelib/list_as_map_test.dart (right):

https://codereview.chromium.org/12391046/diff/1/tests/corelib/list_as_map_tes...
tests/corelib/list_as_map_test.dart:55: if (!canBeModified) return;
On 2013/03/04 08:28:37, Lasse Reichstein Nielsen wrote:
> Instead of passing anonymous booleans, you can have three functions:
> testConstAsMap, testFixedAsMap, testAsMap, with that last two  calling the
prior
> one as well as adding its own tests.

Done.

[floitsch, 2013-03-04 16:58:07]

Committed patchset #2 manually as r19399 (presubmit successful).