Issue 12391010: Make HashSet.length constant time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12391010: Make HashSet.length constant time. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make HashSet.length constant time. Ditto for SplayTree iterators and fix bug in ListIterable.isEmpty. Add test for quickness of .length and .isEmpty of String, Maps and Collections. Not fast enough, and the test will timeout. BUG=http://dartbug.com/8839 Committed: https://code.google.com/p/dart/source/detail?r=19228

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -1 line)			Patch
M	sdk/lib/_collection_dev/iterable.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_set.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	tests/corelib/collection_length_test.dart	View	1 chunk	+75 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/12391010/diff/1/tests/corelib/collection_length_test.dart File tests/corelib/collection_length_test.dart (right): https://codereview.chromium.org/12391010/diff/1/tests/corelib/collection_length_test.dart#newcode1 tests/corelib/collection_length_test.dart:1: // Copyright (c) 2011, the Dart project authors. Please ...

7 years, 9 months ago (2013-02-28 11:00:50 UTC) #1

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-02-28 14:14:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19228 (presubmit successful).

Expand Messages | Collapse Messages