Issue 12391003: Reduce the number of times pumpEventQueue pumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12391003: Reduce the number of times pumpEventQueue pumps. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce the number of times pumpEventQueue pumps. r19179 makes pumping the event queue enough more expensive that the scheduled test tests were routinely timing out. Committed: https://code.google.com/p/dart/source/detail?r=19197

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/scheduled_test/lib/src/utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r19197 (presubmit successful).

7 years, 9 months ago (2013-02-28 01:22:47 UTC) #3

siva

7 years, 9 months ago (2013-02-28 01:25:56 UTC) #4

Message was sent while issue was closed.

Any ideas why it became more expensive? Are you collecting stack traces in
pumpEventQueue?

Expand Messages | Collapse Messages