Issue 1239013002: Use the test runner on the bots.

Issue 1239013002: Use the test runner on the bots. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/shelf@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use the test runner on the bots. R=kevmoo@google.com Committed: https://github.com/dart-lang/shelf/commit/a42b1159d7b73717c16348f05c9268ca82d659fe

Patch Set 2 : Code review changes #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -20 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	.status	View		1 chunk	+0 lines, -18 lines	0 comments	Download
A	.test_config	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/shelf_io_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

https://codereview.chromium.org/1239013002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1239013002/diff/1/pubspec.yaml#newcode17 pubspec.yaml:17: dependency_overrides: huh? https://codereview.chromium.org/1239013002/diff/1/test/shelf_io_test.dart File test/shelf_io_test.dart (right): https://codereview.chromium.org/1239013002/diff/1/test/shelf_io_test.dart#newcode5 test/shelf_io_test.dart:5: @TestOn('vm') ...

5 years, 5 months ago (2015-07-16 01:40:57 UTC) #2

nweiz

5 years, 5 months ago (2015-07-16 20:07:09 UTC) #4

nweiz

5 years, 5 months ago (2015-07-16 20:07:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a42b1159d7b73717c16348f05c9268ca82d659fe (presubmit successful).

Expand Messages | Collapse Messages