Added a rudimentary DOM, to assist with event dispatch.

Added a rudimentary DOM, to assist with event dispatch.
Modified embedder so we can dispatch basic mouse and keyboard events through this new dart:async based plumbing.
Added mouse/motion events to desktop embedder.
Committed: https://code.google.com/p/dart/source/detail?r=19440

[vsm, 2013-03-04 17:34:55]

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
File runtime/embedders/openglui/common/gl.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:15: class HtmlDocument {
I'd rather make this "Document" ... but body is defined only HtmlDocument right
now.  Maybe a TODO to revisit?  It'd be nice not to have the name HTML anywhere.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:18: HtmlDocument() : _body = new
BodyElement();
Can we make these constructors (this and below) private?  I don't think the user
should ever be creating these.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:48: final double clientX, clientY;
These are ints, not doubles in dart:html.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:64: void onData(handler) =>
_stream.onData(_id, handler);
Probably should declare:
typedef void EventListener(Event event)

and just use this type for handler.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:67: class Stream {
These will conflict with the names in dart:async.  We should be able to use that
library alongside ours.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:73: void onData(id, handler) {
types for args

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:77: listen(callback) {
types for args

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:125: onKeyDown(int when, int keyCode,
bool alt, bool ctrl, bool shift, int repeat)
Do you really want these to be globally visible?  (Instead of _onKeyDown?)

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:155: CanvasElement({int width, int
height})
Can we have more than one Canvas right now?

[gram, 2013-03-04 23:53:14]

PTAL

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
File runtime/embedders/openglui/common/gl.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:15: class HtmlDocument {
On 2013/03/04 17:34:55, vsm wrote:
> I'd rather make this "Document" ... but body is defined only HtmlDocument
right
> now.  Maybe a TODO to revisit?  It'd be nice not to have the name HTML
anywhere.
> 

Changed to OpenGLUIDocument. As the user just uses the document singleton, that
should be fine.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:18: HtmlDocument() : _body = new
BodyElement();
On 2013/03/04 17:34:55, vsm wrote:
> Can we make these constructors (this and below) private?  I don't think the
user
> should ever be creating these.

I'm familiar with doing this in Cxx/Java when implementing Singletons, but how
would you do that in Dart?

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:48: final double clientX, clientY;
On 2013/03/04 17:34:55, vsm wrote:
> These are ints, not doubles in dart:html.

Done.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:64: void onData(handler) =>
_stream.onData(_id, handler);
On 2013/03/04 17:34:55, vsm wrote:
> Probably should declare:
> typedef void EventListener(Event event)
> 
> and just use this type for handler.

Done.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:67: class Stream {
On 2013/03/04 17:34:55, vsm wrote:
> These will conflict with the names in dart:async.  We should be able to use
that
> library alongside ours.

Modified the code to work with async library.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:73: void onData(id, handler) {
On 2013/03/04 17:34:55, vsm wrote:
> types for args

Done.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:77: listen(callback) {
On 2013/03/04 17:34:55, vsm wrote:
> types for args

Done.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:125: onKeyDown(int when, int keyCode,
bool alt, bool ctrl, bool shift, int repeat)
On 2013/03/04 17:34:55, vsm wrote:
> Do you really want these to be globally visible?  (Instead of _onKeyDown?)

They have to be callable from vmglue.cc. Would they work if they were private?

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:155: CanvasElement({int width, int
height})
On 2013/03/04 17:34:55, vsm wrote:
> Can we have more than one Canvas right now?

Yes. Currently we can have just one canvas that is bound to the physical display
(this is the first canvas), but we can have multiple memory-backed canvases.

[vsm, 2013-03-05 00:23:58]

LGTM with nits

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
File runtime/embedders/openglui/common/gl.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:18: HtmlDocument() : _body = new
BodyElement();
On 2013/03/04 23:53:14, gram wrote:
> On 2013/03/04 17:34:55, vsm wrote:
> > Can we make these constructors (this and below) private?  I don't think the
> user
> > should ever be creating these.
> 
> I'm familiar with doing this in Cxx/Java when implementing Singletons, but how
> would you do that in Dart? 

The usual pattern is:
   HtmlDocument._internal() : ...;

and, below:
  new HtmlDocument._internal();

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:125: onKeyDown(int when, int keyCode,
bool alt, bool ctrl, bool shift, int repeat)
I'm pretty sure it will work fine.  Dartium does it for creating Dart DOM nodes.

On 2013/03/04 23:53:14, gram wrote:
> On 2013/03/04 17:34:55, vsm wrote:
> > Do you really want these to be globally visible?  (Instead of _onKeyDown?)
> 
> They have to be callable from vmglue.cc. Would they work if they were private?
>

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
File samples/openglui/src/openglui_canvas_tests.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:656: int testnum = 0; //-1; //
Start with latest.
Did you mean to keep this change?  If so, delete the "//-1;"?

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:769: static num dot(Vector v1,
Vector v2)  => v1.x * v2.x + v1.y * v2.y + v1.z * v2.z;
line len

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:769: static num dot(Vector v1,
Vector v2)  => v1.x * v2.x + v1.y * v2.y + v1.z * v2.z;
len

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:796: static String
toDrawingRGB(Color c) =>"rgb(${_intColor(c.r)}, ${_intColor(c.g)},
${_intColor(c.b)})";
line

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:890:
CustomSurface(this.diffuseColor, this.specularColor, this.reflectPos,
this.roughness);
length

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:944: var normal =
isect.thing.normal(pos);
Ditto line length for the next few methods.

[gram, 2013-03-05 01:06:49]

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
File runtime/embedders/openglui/common/gl.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:18: HtmlDocument() : _body = new
BodyElement();
On 2013/03/05 00:23:58, vsm wrote:
> On 2013/03/04 23:53:14, gram wrote:
> > On 2013/03/04 17:34:55, vsm wrote:
> > > Can we make these constructors (this and below) private?  I don't think
the
> > user
> > > should ever be creating these.
> > 
> > I'm familiar with doing this in Cxx/Java when implementing Singletons, but
how
> > would you do that in Dart? 
> 
> The usual pattern is:
>    HtmlDocument._internal() : ...;
> 
> and, below:
>   new HtmlDocument._internal();

Done.

https://chromiumcodereview.appspot.com/12390045/diff/5002/runtime/embedders/o...
runtime/embedders/openglui/common/gl.dart:125: onKeyDown(int when, int keyCode,
bool alt, bool ctrl, bool shift, int repeat)
On 2013/03/05 00:23:58, vsm wrote:
> I'm pretty sure it will work fine.  Dartium does it for creating Dart DOM
nodes.
> 
> On 2013/03/04 23:53:14, gram wrote:
> > On 2013/03/04 17:34:55, vsm wrote:
> > > Do you really want these to be globally visible?  (Instead of _onKeyDown?)
> > 
> > They have to be callable from vmglue.cc. Would they work if they were
private?
> > 
> 

I tried, but it didn't work:

Invoke _onMouseDown failed: Dart_Invoke: did not find top-level function
'_onMouseDown'.

I've changed the names to something less likely to result in a collision by
adding an underscore on the end instead.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
File samples/openglui/src/openglui_canvas_tests.dart (right):

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:656: int testnum = 0; //-1; //
Start with latest.
On 2013/03/05 00:23:58, vsm wrote:
> Did you mean to keep this change?  If so, delete the "//-1;"?

Done.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:769: static num dot(Vector v1,
Vector v2)  => v1.x * v2.x + v1.y * v2.y + v1.z * v2.z;
On 2013/03/05 00:23:58, vsm wrote:
> line len

Done.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:769: static num dot(Vector v1,
Vector v2)  => v1.x * v2.x + v1.y * v2.y + v1.z * v2.z;
On 2013/03/05 00:23:58, vsm wrote:
> len

Done.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:796: static String
toDrawingRGB(Color c) =>"rgb(${_intColor(c.r)}, ${_intColor(c.g)},
${_intColor(c.b)})";
On 2013/03/05 00:23:58, vsm wrote:
> line

Done.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:890:
CustomSurface(this.diffuseColor, this.specularColor, this.reflectPos,
this.roughness);
On 2013/03/05 00:23:58, vsm wrote:
> length

Done.

https://chromiumcodereview.appspot.com/12390045/diff/13001/samples/openglui/s...
samples/openglui/src/openglui_canvas_tests.dart:944: var normal =
isect.thing.normal(pos);
On 2013/03/05 00:23:58, vsm wrote:
> Ditto line length for the next few methods.

Done.

[gram, 2013-03-05 01:07:16]

Committed patchset #4 manually as r19440 (presubmit successful).