Make sure field initializers have access to the type variables.

Make sure field initializers have access to the type variables.
Committed: https://code.google.com/p/dart/source/detail?r=19217

[ngeoffray, 2013-02-28 12:05:10]

This CL fixes the buildbot. There is another bug with type substitution revealed
by the test, but we can submit this CL for going back to green.

https://codereview.chromium.org/12390010/diff/1004/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/12390010/diff/1004/tests/language/language_da...
tests/language/language_dart2js.status:94: type_variable_field_initializer_test:
Fail # TODO(ngeoffray): working on it.
Crashes before this fix.

[karlklose, 2013-02-28 12:08:28]

LGTM.

[ngeoffray, 2013-02-28 12:26:27]

@Lasse: could you take a look at the splay_tree.dart file?
@Johnni, Karl: the problem is in isSubtype with typedefs with type variables...

[Lasse Reichstein Nielsen, 2013-02-28 12:34:19]

lgtm

https://codereview.chromium.org/12390010/diff/6001/sdk/lib/collection/splay_t...
File sdk/lib/collection/splay_tree.dart (right):

https://codereview.chromium.org/12390010/diff/6001/sdk/lib/collection/splay_t...
sdk/lib/collection/splay_tree.dart:230: Function /* TODO(dart2js-team):
re-enable Comparator<K> */_comparator;
Is this the same problem as http://dartbug.com/7733
(I keep forgetting it doesn't work).
If so, add 7733 here, like the other places that are commented out due to that
issue.

[ngeoffray, 2013-02-28 12:37:09]

Thanks Lasse.

https://codereview.chromium.org/12390010/diff/6001/sdk/lib/collection/splay_t...
File sdk/lib/collection/splay_tree.dart (right):

https://codereview.chromium.org/12390010/diff/6001/sdk/lib/collection/splay_t...
sdk/lib/collection/splay_tree.dart:230: Function /* TODO(dart2js-team):
re-enable Comparator<K> */_comparator;
On 2013/02/28 12:34:19, Lasse Reichstein Nielsen wrote:
> Is this the same problem as http://dartbug.com/7733
> (I keep forgetting it doesn't work).
> If so, add 7733 here, like the other places that are commented out due to that
> issue.

Yes, same bug. Done.

[ngeoffray, 2013-02-28 12:49:04]

Committed patchset #4 manually as r19217 (presubmit successful).