Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 12389056: Add Duration.inMicroseconds and add Stopwatch.elapsed. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Duration.inMicroseconds and add Stopwatch.elapsed. Committed: https://code.google.com/p/dart/source/detail?r=19406

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -88 lines) Patch
M sdk/lib/core/duration.dart View 6 chunks +66 lines, -51 lines 2 comments Download
M sdk/lib/core/stopwatch.dart View 5 chunks +25 lines, -9 lines 0 comments Download
M tests/corelib/duration_test.dart View 3 chunks +87 lines, -28 lines 0 comments Download
A tests/corelib/stopwatch2_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
Note: this CL also makes Duration non-implementable (since it has a private member now).
7 years, 9 months ago (2013-03-01 18:10:12 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/12389056/diff/1/sdk/lib/core/duration.dart File sdk/lib/core/duration.dart (right): https://codereview.chromium.org/12389056/diff/1/sdk/lib/core/duration.dart#newcode44 sdk/lib/core/duration.dart:44: final int _duration; Why not name it inMicroseconds ...
7 years, 9 months ago (2013-03-04 09:11:05 UTC) #2
floitsch
https://codereview.chromium.org/12389056/diff/1/sdk/lib/core/duration.dart File sdk/lib/core/duration.dart (right): https://codereview.chromium.org/12389056/diff/1/sdk/lib/core/duration.dart#newcode44 sdk/lib/core/duration.dart:44: final int _duration; On 2013/03/04 09:11:05, Lasse Reichstein Nielsen ...
7 years, 9 months ago (2013-03-04 18:02:28 UTC) #3
floitsch
7 years, 9 months ago (2013-03-04 18:13:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698