Issue 12389050: Remane io_stream_consumer.dart to io_sink and move out all implementation from IOSink to _IOSinkImp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12389050: Remane io_stream_consumer.dart to io_sink and move out all implementation from IOSink to _IOSinkImp… (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 9 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remane io_stream_consumer.dart to io_sink and move out all implementation from IOSink to _IOSinkImpl. BUG=https://code.google.com/p/dart/issues/detail?id=8873 Committed: https://code.google.com/p/dart/source/detail?r=19311

Patch Set 1 #

Patch Set 2 : Make _DetachedSocket pass dart-analyzer. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -220 lines)			Patch
M	sdk/lib/io/http_impl.dart	View	1	7 chunks	+28 lines, -18 lines	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/io/io_sink.dart	View		6 chunks	+39 lines, -21 lines	0 comments	Download
D	sdk/lib/io/io_stream_consumer.dart	View		1 chunk	+0 lines, -173 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_date_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_headers_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/http_parser_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/mime_multipart_parser_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 9 months ago (2013-03-01 13:33:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19311 (presubmit successful).

Expand Messages | Collapse Messages