Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 12389049: Fix --host-checked mode and add proper canBePrimitive method to HBoundedType. (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix --host-checked mode and add proper canBePrimitive method to HBoundedType. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19305

Patch Set 1 #

Patch Set 2 : Remove type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/type_mask.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 9 months ago (2013-03-01 12:44:03 UTC) #1
ngeoffray
LGTM
7 years, 9 months ago (2013-03-01 12:45:17 UTC) #2
kasperl
7 years, 9 months ago (2013-03-01 12:46:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698