Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12389025: Do not register typechecks against type variables of typedefs. (Closed)

Created:
7 years, 9 months ago by karlklose
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not register typechecks against type variables of typedefs. Committed: https://code.google.com/p/dart/source/detail?r=19286

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move check to the resolver. #

Patch Set 3 : Add a helper. #

Total comments: 2

Patch Set 4 : Change inCheckContext for typedef contexts. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
karlklose
7 years, 9 months ago (2013-02-28 16:45:41 UTC) #1
ngeoffray
https://codereview.chromium.org/12389025/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart File sdk/lib/_internal/compiler/implementation/enqueue.dart (right): https://codereview.chromium.org/12389025/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart#newcode359 sdk/lib/_internal/compiler/implementation/enqueue.dart:359: // Do not register checks against type-variables of typedefs. ...
7 years, 9 months ago (2013-02-28 16:56:19 UTC) #2
karlklose
https://codereview.chromium.org/12389025/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart File sdk/lib/_internal/compiler/implementation/enqueue.dart (right): https://codereview.chromium.org/12389025/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart#newcode359 sdk/lib/_internal/compiler/implementation/enqueue.dart:359: // Do not register checks against type-variables of typedefs. ...
7 years, 9 months ago (2013-02-28 17:16:45 UTC) #3
ngeoffray
https://codereview.chromium.org/12389025/diff/5002/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12389025/diff/5002/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1640 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640: inCheckContext = compiler.enableTypeAssertions, If you did inCheckContext = compiler.enableTypeAssertions ...
7 years, 9 months ago (2013-02-28 20:08:42 UTC) #4
karlklose
https://codereview.chromium.org/12389025/diff/5002/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12389025/diff/5002/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1640 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640: inCheckContext = compiler.enableTypeAssertions, That works, too, using the enclosingElement. ...
7 years, 9 months ago (2013-03-01 08:23:38 UTC) #5
ngeoffray
LGTM! Thanks Karl. https://codereview.chromium.org/12389025/diff/9001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12389025/diff/9001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1641 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1641: !element.enclosingElement.isTypedef(), Please add a comment.
7 years, 9 months ago (2013-03-01 08:36:00 UTC) #6
karlklose
7 years, 9 months ago (2013-03-01 09:09:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r19286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698