Issue 12388094: Removing futureTest test method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12388094: Removing futureTest test method (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Removing futureTest test method The functionality has been rolled into test(). BUG= Committed: https://code.google.com/p/dart/source/detail?r=19441

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -41 lines)			Patch
M	tests/html/indexeddb_1_test.dart	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	tests/html/indexeddb_2_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	1 chunk	+13 lines, -13 lines	2 comments	Download
M	tests/html/indexeddb_5_test.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/html/utils.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/html/websql_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Emily Fortuna

lgtm after removing the imports. Does this mean there should be another CL converting all ...

7 years, 9 months ago (2013-03-04 22:48:37 UTC) #2

blois

Not going to remove all of them at once, just refactor as we go. I ...

7 years, 9 months ago (2013-03-05 01:11:37 UTC) #3

blois

7 years, 9 months ago (2013-03-05 01:12:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19441 (presubmit successful).