Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 12388048: Cleanup two warning messages when running apidoc, and update the apidoc.gyp file to rerun the tool (Closed)

Created:
7 years, 9 months ago by devoncarew
Modified:
7 years, 8 months ago
Reviewers:
ahe, Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup two warning messages when running apidoc, and update the apidoc.gyp file to rerun the tool when any of its dart source changes. Committed: https://code.google.com/p/dart/source/detail?r=19336

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M utils/apidoc/apidoc.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +3 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
devoncarew
Andrei, this cleans up two warnings about the .svn and pkg.xcodeproj directories (which apidoc was ...
7 years, 9 months ago (2013-03-01 17:20:02 UTC) #1
Andrei Mouravski
lgtm
7 years, 9 months ago (2013-03-01 18:04:23 UTC) #2
devoncarew
Committed patchset #2 manually as r19336 (presubmit successful).
7 years, 9 months ago (2013-03-01 20:01:09 UTC) #3
ahe
I strongly encourage you to ask me to review GYP changes. https://codereview.chromium.org/12388048/diff/2001/utils/apidoc/apidoc.gyp File utils/apidoc/apidoc.gyp (right): ...
7 years, 8 months ago (2013-04-05 19:01:00 UTC) #4
devoncarew
https://codereview.chromium.org/12388048/diff/2001/utils/apidoc/apidoc.gyp File utils/apidoc/apidoc.gyp (right): https://codereview.chromium.org/12388048/diff/2001/utils/apidoc/apidoc.gyp#newcode41 utils/apidoc/apidoc.gyp:41: 'inputs': [ On 2013/04/05 19:01:00, ahe wrote: > This ...
7 years, 8 months ago (2013-04-05 19:09:21 UTC) #5
ahe
7 years, 8 months ago (2013-04-05 19:13:38 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/12388048/diff/2001/utils/apidoc/apidoc.gyp
File utils/apidoc/apidoc.gyp (right):

https://codereview.chromium.org/12388048/diff/2001/utils/apidoc/apidoc.gyp#ne...
utils/apidoc/apidoc.gyp:41: 'inputs': [
On 2013/04/05 19:09:21, devoncarew wrote:
> On 2013/04/05 19:01:00, ahe wrote:
> > This overwrites the previous value of 'inputs'.  Now apidoc isn't being
re-run
> > as the SDK changes, and neither if dartdoc has changed.
> 
> Sorry, my bad. I had noticed that it wasn't being re-run when apidoc.dart
itself
> changed, which was the problem I was originally trying to solve.

No worries. GYP is so complicated, that's why I really don't mind getting
spammed with GYP changes, as I seem to have a knack for spotting problems :-)

I've already sent you an CL to fix it.

Powered by Google App Engine
This is Rietveld 408576698