Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1238803002: Make observatory tests analyzer clean (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M runtime/observatory/tests/service/address_mapper_test.dart View 1 1 chunk +40 lines, -15 lines 0 comments Download
M runtime/observatory/tests/service/library_dependency_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_exceptions_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/read_stream_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 5 months ago (2015-07-14 20:40:53 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1238803002/diff/1/runtime/observatory/tests/service/read_stream_test.dart File runtime/observatory/tests/service/read_stream_test.dart (right): https://codereview.chromium.org/1238803002/diff/1/runtime/observatory/tests/service/read_stream_test.dart#newcode27 runtime/observatory/tests/service/read_stream_test.dart:27: expect((n >> 0) & 0xFFFFFFF, equals(stream.low)); Really, these ...
5 years, 5 months ago (2015-07-14 20:44:47 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as b6b3c3e93b2dd142c46c31e10bf22e6dff8e745d (presubmit successful).
5 years, 5 months ago (2015-07-14 20:49:13 UTC) #4
Cutch
5 years, 5 months ago (2015-07-14 20:49:15 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1238803002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/read_stream_test.dart (right):

https://codereview.chromium.org/1238803002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/read_stream_test.dart:27: expect((n >>  0) &
0xFFFFFFF, equals(stream.low));
On 2015/07/14 20:44:47, rmacnak wrote:
> Really, these should all flip so the expected value is on the right now.

Done.

Powered by Google App Engine
This is Rietveld 408576698