Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 12387039: Check if the element is a typedef (Closed)

Created:
7 years, 9 months ago by karlklose
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check if the element is a typedef and add a comment. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=19292

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Add TODO with issue reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
7 years, 9 months ago (2013-03-01 11:17:25 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/12387039/diff/3/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12387039/diff/3/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1640 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640: // The type annotations on a typedef do ...
7 years, 9 months ago (2013-03-01 11:18:15 UTC) #2
karlklose
Thanks, Nicolas. https://codereview.chromium.org/12387039/diff/3/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12387039/diff/3/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1640 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640: // The type annotations on a typedef ...
7 years, 9 months ago (2013-03-01 11:22:57 UTC) #3
karlklose
7 years, 9 months ago (2013-03-01 11:31:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r19292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698