Issue 12387033: Disable breaking tests while I investigate the issue. I don't really want to revert;

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12387033: Disable breaking tests while I investigate the issue. I don't really want to revert; (Closed)

Created:
7 years, 9 months ago by gram

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable breaking tests while I investigate the issue. I don't really want to revert; I want to understand this as it may indicate some other problem. Committed: https://code.google.com/p/dart/source/detail?r=19271

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	utils/tests/pub/pub.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Two requests then LGTM. https://codereview.chromium.org/12387033/diff/1/utils/tests/pub/pub.status File utils/tests/pub/pub.status (right): https://codereview.chromium.org/12387033/diff/1/utils/tests/pub/pub.status#newcode10 utils/tests/pub/pub.status:10: error_group_test: Skip If it's consistently ...

7 years, 9 months ago (2013-03-01 01:35:15 UTC) #2

gram

7 years, 9 months ago (2013-03-01 01:39:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19271 (presubmit successful).

Expand Messages | Collapse Messages