Issue 12387019: Fix null-termination bug in Stacktrace::ToCString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12387019: Fix null-termination bug in Stacktrace::ToCString. (Closed)

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix null-termination bug in Stacktrace::ToCString. Under certain conditions Stacktrace::ToCString can return a not null-terminated string. This is the case when ToCStringInternal is invoked with a stacktrace of length 0. BUG=dart:8850 TEST=tests/language/stacktrace_test.dart Committed: https://code.google.com/p/dart/source/detail?r=19282

Patch Set 1 #

Patch Set 2 : adjusted dart2js status file #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
M	runtime/vm/object.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/stacktrace_test.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Hi Siva, This happens if Stacktrace::FullStacktrace() appends an empty catch-trace to the stack trace, but ...

7 years, 9 months ago (2013-02-28 17:24:19 UTC) #1

Florian Schneider

7 years, 9 months ago (2013-03-01 09:03:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19282 (presubmit successful).

Expand Messages | Collapse Messages