Add --csp flag to test.dart.

Add --csp flag to test.dart.

When running test with that flag we make sure the HTTP server emits
Content-Security-Policy restriction headers and we pass --disallow-unsafe-eval
to dart2js.

R=ricow@google.com,kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=19208

[kustermann, 2013-02-28 08:34:49]

lgtm

https://codereview.chromium.org/12387010/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/12387010/diff/1/tools/test.dart#newcode126
tools/test.dart:126: useContentSecurityPolicy);
Since the second parameter is not optional, you need to change that in
'tools/test-runtime.dart' as well.

[ricow1, 2013-02-28 08:36:06]

LGTM

https://codereview.chromium.org/12387010/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/12387010/diff/1/tools/test.dart#newcode126
tools/test.dart:126: useContentSecurityPolicy);
You also need to do this in tools/test-runtime.dart

https://codereview.chromium.org/12387010/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12387010/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:283: // Chrome respects the standardized
Content-Security-Policy header, but
but whereas -> whereas

[sra1, 2013-02-28 08:38:09]

How about renaming the dart2js flag to --csp at the same time?

[kasperl, 2013-02-28 08:54:49]

https://codereview.chromium.org/12387010/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/12387010/diff/1/tools/test.dart#newcode126
tools/test.dart:126: useContentSecurityPolicy);
On 2013/02/28 08:36:07, ricow1 wrote:
> You also need to do this in tools/test-runtime.dart

I'll do that, but I *strongly* object to this. I don't want to worry about a
degenerated runtime-specific checkout of a subset of the system when working on
the testing infrastructure. I suggest we just delete test-runtime.dart
completely right now and *force* everybody to use the same checkout.

[kasperl, 2013-02-28 08:59:41]

Committed patchset #2 manually as r19208 (presubmit successful).

[ricow1, 2013-02-28 09:07:06]

On 2013/02/28 08:54:49, kasperl wrote:
> https://codereview.chromium.org/12387010/diff/1/tools/test.dart
> File tools/test.dart (right):
> 
> https://codereview.chromium.org/12387010/diff/1/tools/test.dart#newcode126
> tools/test.dart:126: useContentSecurityPolicy);
> On 2013/02/28 08:36:07, ricow1 wrote:
> > You also need to do this in tools/test-runtime.dart
> 
> I'll do that, but I *strongly* object to this. I don't want to worry about a
> degenerated runtime-specific checkout of a subset of the system when working
on
> the testing infrastructure. I suggest we just delete test-runtime.dart
> completely right now and *force* everybody to use the same checkout.
+1 but I am not sure vm guys agree