Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 12386079: Mark tests/co19/LibTest/math/exp_A01_t01 Fail, OK due to co19 issue 44 for Windows platform. (Closed)

Created:
7 years, 9 months ago by aam-me
Modified:
7 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark tests/co19/LibTest/math/exp_A01_t01 Fail, OK due to co19 issue 44 for Windows platform. Committed: https://code.google.com/p/dart/source/detail?r=19447

Patch Set 1 #

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/co19/co19-dart2js.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aam-me
Hi, Peter, this test is already marked as failing for Mac and Linux platforms. It ...
7 years, 9 months ago (2013-03-04 05:22:21 UTC) #1
ahe
LGTM!
7 years, 9 months ago (2013-03-04 09:34:57 UTC) #2
aam-me
Committed patchset #2 manually as r19447 (presubmit successful).
7 years, 9 months ago (2013-03-05 01:45:15 UTC) #3
aam-me
7 years, 9 months ago (2013-03-05 01:49:10 UTC) #4
Message was sent while issue was closed.
On 2013/03/04 09:34:57, ahe wrote:
> LGTM!

Thank you, Peter.
I had to patch it again, my first patch (#1) had Fail, OK commented out, which
was typo.

Powered by Google App Engine
This is Rietveld 408576698