Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 12386030: - Remove the --no-use-inlining flag as it is not beneficial as the compiled programs grow. (Closed)

Created:
7 years, 9 months ago by Ivan Posva
Modified:
7 years, 9 months ago
Reviewers:
ahe, srdjan, kasperl
CC:
reviews_dartlang.org, srdjan, ahe
Visibility:
Public.

Description

- Remove the --no-use-inlining flag as it is not beneficial as the compiled programs grow. Committed: https://code.google.com/p/dart/source/detail?r=19559

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M sdk/bin/dart2js View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/bin/dart2js.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js_developer.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ivan Posva
Kasper, As discussed yesterday: The removal of the --no-use-inlining flag from the dart2js related scripts. ...
7 years, 9 months ago (2013-02-28 21:08:23 UTC) #1
srdjan
lgtm
7 years, 9 months ago (2013-02-28 21:14:52 UTC) #2
ahe
I have some concerns about this. Could you give me a chance to talk to ...
7 years, 9 months ago (2013-03-01 06:18:43 UTC) #3
ahe
lgtm
7 years, 9 months ago (2013-03-06 14:43:44 UTC) #4
Ivan Posva
7 years, 9 months ago (2013-03-06 14:46:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698