Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 12385090: Further HTML test cleanup (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Further HTML test cleanup BUG= Committed: https://code.google.com/p/dart/source/detail?r=19423

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -134 lines) Patch
M tests/html/html.status View 6 chunks +0 lines, -13 lines 2 comments Download
D tests/html/inner_frame_test.dart View 1 chunk +0 lines, -120 lines 1 comment Download
M tests/html/messageevent_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
https://codereview.chromium.org/12385090/diff/5001/tests/html/inner_frame_test.dart File tests/html/inner_frame_test.dart (left): https://codereview.chromium.org/12385090/diff/5001/tests/html/inner_frame_test.dart#oldcode13 tests/html/inner_frame_test.dart:13: window.onMessage.listen((Event e) { This test is horribly broken because ...
7 years, 9 months ago (2013-03-04 19:30:05 UTC) #1
Emily Fortuna
https://codereview.chromium.org/12385090/diff/5001/tests/html/html.status File tests/html/html.status (left): https://codereview.chromium.org/12385090/diff/5001/tests/html/html.status#oldcode17 tests/html/html.status:17: input_element_test/supported_date: Pass, Fail # Chrome stable does not support ...
7 years, 9 months ago (2013-03-04 19:32:33 UTC) #2
blois
https://codereview.chromium.org/12385090/diff/5001/tests/html/html.status File tests/html/html.status (left): https://codereview.chromium.org/12385090/diff/5001/tests/html/html.status#oldcode17 tests/html/html.status:17: input_element_test/supported_date: Pass, Fail # Chrome stable does not support ...
7 years, 9 months ago (2013-03-04 19:45:50 UTC) #3
Emily Fortuna
lgtm
7 years, 9 months ago (2013-03-04 19:47:53 UTC) #4
blois
7 years, 9 months ago (2013-03-04 21:44:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r19423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698