Issue 12385079: Handle void correctly in function subtyping.

Issue 12385079: Handle void correctly in function subtyping. (Closed)

Created:
7 years, 9 months ago by Johnni Winther

Modified:
7 years, 9 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle void correctly in function subtyping. - and fix hashCode. Committed: https://code.google.com/p/dart/source/detail?r=19547

Patch Set 2 : Updated cf. comment #

Patch Set 4 : Status updated #

Patch Set 5 : Rebased #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/12385079/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/12385079/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode935 sdk/lib/_internal/compiler/implementation/dart_types.dart:935: if (!identical(sf.returnType, voidType)) { Use '&&' instead of ...

7 years, 9 months ago (2013-03-04 12:20:37 UTC) #2

Johnni Winther

https://codereview.chromium.org/12385079/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/12385079/diff/1/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode935 sdk/lib/_internal/compiler/implementation/dart_types.dart:935: if (!identical(sf.returnType, voidType)) { On 2013/03/04 12:20:37, karlklose wrote: ...

7 years, 9 months ago (2013-03-06 09:53:54 UTC) #3

Johnni Winther

7 years, 9 months ago (2013-03-06 10:46:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r19547 (presubmit successful).

Expand Messages | Collapse Messages