Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 12385044: CompileType::ToNullableCid must check whether type is implemented in addition to checking whether t… (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, regis, srdjan
Visibility:
Public.

Description

CompileType::ToNullableCid must check whether type is implemented This should be done in addition to checking whether type has subclasses as subtyping relation is defined in terms of interfaces. Otherwise type propagation infers that result of a mint operation has a kIntegerCid because IntType has no subclasses. It is only appropriate to not take subinterfaces into account when inferring cid of the receiver. No regression test included because currently it is not possible to write one: fact that we inferred kIntegerCid for result of mint operations is not observable and for other IR instructions nullability prevents us from infering anything but kDynamicCid. R=kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19322

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 1 3 chunks +30 lines, -23 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
Kevin please take a look.
7 years, 9 months ago (2013-03-01 13:34:14 UTC) #1
Kevin Millikin (Google)
LGTM.
7 years, 9 months ago (2013-03-01 13:55:03 UTC) #2
Vyacheslav Egorov (Google)
7 years, 9 months ago (2013-03-01 16:31:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698