Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 12385041: Don't close the server until we have received the error. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't close the server until we have received the error. This avoids a scenerio where server.close would destroy the socket before we would receive the error, if the validator stream is paused from the socket. BUG=https://code.google.com/p/dart/issues/detail?id=8865 Committed: https://code.google.com/p/dart/source/detail?r=19299

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tests/standalone/io/http_content_length_test.dart View 1 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 9 months ago (2013-03-01 09:48:41 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/12385041/diff/1/tests/standalone/io/http_content_length_test.dart File tests/standalone/io/http_content_length_test.dart (right): https://codereview.chromium.org/12385041/diff/1/tests/standalone/io/http_content_length_test.dart#newcode95 tests/standalone/io/http_content_length_test.dart:95: Expect.isTrue(e.error is HttpException, "[$e] [${e.error}]"); Long line (not ...
7 years, 9 months ago (2013-03-01 11:51:19 UTC) #2
Anders Johnsen
Landing. https://codereview.chromium.org/12385041/diff/1/tests/standalone/io/http_content_length_test.dart File tests/standalone/io/http_content_length_test.dart (right): https://codereview.chromium.org/12385041/diff/1/tests/standalone/io/http_content_length_test.dart#newcode95 tests/standalone/io/http_content_length_test.dart:95: Expect.isTrue(e.error is HttpException, "[$e] [${e.error}]"); On 2013/03/01 11:51:19, ...
7 years, 9 months ago (2013-03-01 12:26:54 UTC) #3
Anders Johnsen
7 years, 9 months ago (2013-03-01 12:29:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698