Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 12385027: Make use of Completer.isComplete in pub and pkg/scheduled_test. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make use of Completer.isComplete in pub and pkg/scheduled_test. Committed: https://code.google.com/p/dart/source/detail?r=19264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M pkg/scheduled_test/test/utils.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M utils/pub/io.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 9 months ago (2013-02-28 22:38:42 UTC) #1
Bob Nystrom
lgtm
7 years, 9 months ago (2013-02-28 23:13:09 UTC) #2
nweiz
7 years, 9 months ago (2013-02-28 23:18:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698