Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 12385024: Make sure that no decrypted text gets stuck in the plaintext buffer (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make sure that no decrypted text gets stuck in the plaintext buffer When read events are enabled on a raw secure sockets, we need to fire off a read event if there is data in the plaintext buffer. We cannot rely on the underlying raw socket firing off another read event even if it is open. R=whesse@google.com BUG=https://code.google.com/p/dart/issues/detail?id=8824 Committed: https://code.google.com/p/dart/source/detail?r=19247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sdk/lib/io/secure_socket.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-02-28 17:01:32 UTC) #1
Bill Hesse
LGTM.
7 years, 9 months ago (2013-02-28 17:10:33 UTC) #2
Søren Gjesse
7 years, 9 months ago (2013-02-28 17:16:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698