Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 12385015: Clarify some documentation around runes, aka code points (Closed)

Created:
7 years, 9 months ago by erikcorry
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clarify some documentation around runes, aka code points Fix URLs in README R=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19911

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M README View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/core/string.dart View 6 chunks +16 lines, -12 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
erikcorry
7 years, 9 months ago (2013-02-28 12:27:14 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/12385015/diff/1/sdk/lib/core/string.dart File sdk/lib/core/string.dart (right): https://codereview.chromium.org/12385015/diff/1/sdk/lib/core/string.dart#newcode304 sdk/lib/core/string.dart:304: /** [Iterator] for reading runes (21 bit integer ...
7 years, 9 months ago (2013-02-28 12:31:21 UTC) #2
erikcorry
7 years, 9 months ago (2013-03-13 08:32:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698