Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 12385007: Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http. This re-commits r19185, with all package: imports removed from pkg/http so that it can transitively depend on pkg/path without breaking pub. This also marks pkg/http/multipart_test as skipped temporarily (see issue 8843). Committed: https://code.google.com/p/dart/source/detail?r=19194

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M pkg/http/lib/src/multipart_file.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/client_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/http_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/mock_client_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/http/test/multipart_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/request_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/response_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/streamed_request_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/utils.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 9 months ago (2013-02-28 00:43:19 UTC) #1
Bob Nystrom
Take a look at tools/publish_pkg.py to see how it fixes up those relative imports. https://codereview.chromium.org/12385007/diff/1/pkg/http/lib/src/multipart_file.dart ...
7 years, 9 months ago (2013-02-28 00:50:57 UTC) #2
nweiz
https://codereview.chromium.org/12385007/diff/1/pkg/http/lib/src/multipart_file.dart File pkg/http/lib/src/multipart_file.dart (right): https://codereview.chromium.org/12385007/diff/1/pkg/http/lib/src/multipart_file.dart#newcode10 pkg/http/lib/src/multipart_file.dart:10: import '../../../pathos/lib/path.dart' as path; On 2013/02/28 00:50:57, Bob Nystrom ...
7 years, 9 months ago (2013-02-28 01:10:54 UTC) #3
Bob Nystrom
LGTM.
7 years, 9 months ago (2013-02-28 01:12:09 UTC) #4
nweiz
7 years, 9 months ago (2013-02-28 01:16:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698